From: Andrew Cooper Date: Mon, 19 Mar 2018 16:50:46 +0000 (+0000) Subject: xen/domain: Call arch_domain_create() as early as possible in domain_create() X-Git-Tag: archive/raspbian/4.14.0+80-gd101b417b7-1+rpi1^2~63^2~3351 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=580c45869;p=xen.git xen/domain: Call arch_domain_create() as early as possible in domain_create() This is in preparation to set up d->max_cpus and d->vcpu[] in domain_create(), and allow later parts of domain construction to have access to the values. Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Reviewed-by: Jan Beulich --- diff --git a/xen/common/domain.c b/xen/common/domain.c index be51426e49..81435321f9 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -322,6 +322,22 @@ struct domain *domain_create(domid_t domid, else d->guest_type = guest_type_pv; + if ( !is_hardware_domain(d) ) + d->nr_pirqs = nr_static_irqs + extra_domU_irqs; + else + d->nr_pirqs = extra_hwdom_irqs ? nr_static_irqs + extra_hwdom_irqs + : arch_hwdom_irqs(domid); + d->nr_pirqs = min(d->nr_pirqs, nr_irqs); + + radix_tree_init(&d->pirq_tree); + } + + if ( (err = arch_domain_create(d, config)) != 0 ) + goto fail; + init_status |= INIT_arch; + + if ( !is_idle_domain(d) ) + { watchdog_domain_init(d); init_status |= INIT_watchdog; @@ -352,16 +368,6 @@ struct domain *domain_create(domid_t domid, d->controller_pause_count = 1; atomic_inc(&d->pause_count); - if ( !is_hardware_domain(d) ) - d->nr_pirqs = nr_static_irqs + extra_domU_irqs; - else - d->nr_pirqs = extra_hwdom_irqs ? nr_static_irqs + extra_hwdom_irqs - : arch_hwdom_irqs(domid); - if ( d->nr_pirqs > nr_irqs ) - d->nr_pirqs = nr_irqs; - - radix_tree_init(&d->pirq_tree); - if ( (err = evtchn_init(d, config->max_evtchn_port)) != 0 ) goto fail; init_status |= INIT_evtchn; @@ -376,14 +382,7 @@ struct domain *domain_create(domid_t domid, d->pbuf = xzalloc_array(char, DOMAIN_PBUF_SIZE); if ( !d->pbuf ) goto fail; - } - if ( (err = arch_domain_create(d, config)) != 0 ) - goto fail; - init_status |= INIT_arch; - - if ( !is_idle_domain(d) ) - { if ( (err = sched_init_domain(d, 0)) != 0 ) goto fail;